Open pull requests to update packages#1097
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe GitHub Actions workflow responsible for updating the Sequence Diagram(s)sequenceDiagram
participant Workflow
participant GitHubRepo
participant AWS
participant NPM
participant PullRequest
Workflow->>GitHubRepo: Checkout code (using ACTIONS_BOT_TOKEN)
Workflow->>AWS: Retrieve AWS credentials and secrets
Workflow->>Workflow: Set up Node.js environment
Workflow->>NPM: Install dependencies
Workflow->>NPM: Run npm update on package
Workflow->>GitHubRepo: Stage and commit changes
Workflow->>PullRequest: Create pull request (via peter-evans/create-pull-request)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/update-extensions.yml(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/update-extensions.yml
52-52: could not parse as YAML: yaml: line 52: mapping values are not allowed in this context
(syntax-check)
🪛 YAMLlint (1.35.1)
.github/workflows/update-extensions.yml
[error] 52-52: syntax error: mapping values are not allowed here
(syntax)
🔇 Additional comments (3)
.github/workflows/update-extensions.yml (3)
7-7: No action needed for formatting or blank-line inserts
These line changes are purely whitespace or blank-line adjustments and don’t affect the workflow’s behavior.Also applies to: 24-24, 30-30
12-14: Permissions updated appropriately for PR creation
Expandingcontentsand addingpull-requeststowritepermission is correct and necessary for thepeter-evans/create-pull-requestaction to push branches and open PRs. Well done.
48-50: Use peter-evans/create-pull-request for automated PRs
Replacing the manualgit commit&git pushsequence with this action is a solid improvement that centralizes and standardizes dependency update pull requests.
| strategy: | ||
| matrix: | ||
| branch: [main, 'v/24.1', 'v/23.3', api] | ||
| branch: [main, 'v24.3', 'v/24.2', 'v/24.1', api] |
There was a problem hiding this comment.
Fix branch naming in the matrix
The entries 'v/24.2' and 'v/24.1' include an extra slash and won’t match your actual branch names (v24.2, v24.1). Please remove the slash so the workflow triggers on the intended branches.
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Description
Review deadline: May 2
This pull request updates the
.github/workflows/update-extensions.ymlfile to enhance the workflow for updating dependencies. The changes include a shift from committing changes directly to creating pull requests.Workflow Enhancements:
Permissions Update: Changed
contentspermission fromreadtowriteand addedpull-requests: writeto enable pull request creation.Branch Matrix Update: Updated the branch matrix to include
v24.3andv24.2while retaining existing branches.Step Modifications:
AWS Secrets and Checkout: Added steps to retrieve AWS secrets and configure credentials, and updated the repository checkout step to use the appropriate branch and token.
Dependency Update Process: Replaced the manual commit and push process with the
peter-evans/create-pull-requestaction to automate pull request creation for dependency updates. This includes setting the commit message, labels, title, and body of the pull request.Page previews
Checks