Skip to content

Open pull requests to update packages#1097

Merged
JakeSCahill merged 4 commits intomainfrom
JakeSCahill-patch-6
May 2, 2025
Merged

Open pull requests to update packages#1097
JakeSCahill merged 4 commits intomainfrom
JakeSCahill-patch-6

Conversation

@JakeSCahill
Copy link
Copy Markdown
Contributor

Description

Review deadline: May 2

This pull request updates the .github/workflows/update-extensions.yml file to enhance the workflow for updating dependencies. The changes include a shift from committing changes directly to creating pull requests.

Workflow Enhancements:

  • Permissions Update: Changed contents permission from read to write and added pull-requests: write to enable pull request creation.

  • Branch Matrix Update: Updated the branch matrix to include v24.3 and v24.2 while retaining existing branches.

Step Modifications:

  • AWS Secrets and Checkout: Added steps to retrieve AWS secrets and configure credentials, and updated the repository checkout step to use the appropriate branch and token.

  • Dependency Update Process: Replaced the manual commit and push process with the peter-evans/create-pull-request action to automate pull request creation for dependency updates. This includes setting the commit message, labels, title, and body of the pull request.

Page previews

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@JakeSCahill JakeSCahill requested a review from a team as a code owner May 2, 2025 08:59
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 2, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

The GitHub Actions workflow responsible for updating the @redpanda-data/docs-extensions-and-macros package has been modified. The permissions for the job have been expanded to allow write access to repository contents and pull requests. The workflow's branch matrix now includes additional branches (v24.3, v/24.2) and corrects a branch name to v24.1. The workflow steps have been reorganized for clarity, explicitly adding Node.js setup and dependency installation before the package update command. The authentication for repository checkout now uses the ACTIONS_BOT_TOKEN. The previous approach of committing and pushing changes directly to the branch has been replaced by the peter-evans/create-pull-request action, which creates a pull request for the update on a dedicated branch, targeting the appropriate base branch and applying a label. No changes were made to any exported or public code entities.

Sequence Diagram(s)

sequenceDiagram
    participant Workflow
    participant GitHubRepo
    participant AWS
    participant NPM
    participant PullRequest

    Workflow->>GitHubRepo: Checkout code (using ACTIONS_BOT_TOKEN)
    Workflow->>AWS: Retrieve AWS credentials and secrets
    Workflow->>Workflow: Set up Node.js environment
    Workflow->>NPM: Install dependencies
    Workflow->>NPM: Run npm update on package
    Workflow->>GitHubRepo: Stage and commit changes
    Workflow->>PullRequest: Create pull request (via peter-evans/create-pull-request)
Loading

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Comment thread .github/workflows/update-extensions.yml Outdated
@netlify
Copy link
Copy Markdown

netlify Bot commented May 2, 2025

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit 2262ba8
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-docs-preview/deploys/681489681bc9800008c64e69
😎 Deploy Preview https://deploy-preview-1097--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ffdc74 and 4593165.

📒 Files selected for processing (1)
  • .github/workflows/update-extensions.yml (1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/update-extensions.yml

52-52: could not parse as YAML: yaml: line 52: mapping values are not allowed in this context

(syntax-check)

🪛 YAMLlint (1.35.1)
.github/workflows/update-extensions.yml

[error] 52-52: syntax error: mapping values are not allowed here

(syntax)

🔇 Additional comments (3)
.github/workflows/update-extensions.yml (3)

7-7: No action needed for formatting or blank-line inserts
These line changes are purely whitespace or blank-line adjustments and don’t affect the workflow’s behavior.

Also applies to: 24-24, 30-30


12-14: Permissions updated appropriately for PR creation
Expanding contents and adding pull-requests to write permission is correct and necessary for the peter-evans/create-pull-request action to push branches and open PRs. Well done.


48-50: Use peter-evans/create-pull-request for automated PRs
Replacing the manual git commit & git push sequence with this action is a solid improvement that centralizes and standardizes dependency update pull requests.

Comment thread .github/workflows/update-extensions.yml Outdated
strategy:
matrix:
branch: [main, 'v/24.1', 'v/23.3', api]
branch: [main, 'v24.3', 'v/24.2', 'v/24.1', api]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix branch naming in the matrix
The entries 'v/24.2' and 'v/24.1' include an extra slash and won’t match your actual branch names (v24.2, v24.1). Please remove the slash so the workflow triggers on the intended branches.

Comment thread .github/workflows/update-extensions.yml
@netlify
Copy link
Copy Markdown

netlify Bot commented May 2, 2025

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit e566dc3
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-docs-preview/deploys/68148d63be45b4000887d569
😎 Deploy Preview https://deploy-preview-1097--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment thread .github/workflows/update-extensions.yml Outdated
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Comment thread .github/workflows/update-extensions.yml Outdated
Comment thread .github/workflows/update-extensions.yml Outdated
Copy link
Copy Markdown
Contributor

@asimms41 asimms41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JakeSCahill JakeSCahill merged commit a7a9839 into main May 2, 2025
8 checks passed
@JakeSCahill JakeSCahill deleted the JakeSCahill-patch-6 branch May 2, 2025 09:38
@coderabbitai coderabbitai Bot mentioned this pull request Aug 28, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants